Skip to content

fix(build): avoid a possible cmake warning about shadowed variables and changing behaviors #3220

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 23, 2021
Merged

fix(build): avoid a possible cmake warning about shadowed variables and changing behaviors #3220

merged 1 commit into from
Sep 23, 2021

Conversation

henryiii
Copy link
Collaborator

Description

This came up in #3212, there are warnings that can be avoided.

Suggested changelog entry:

* Fix a harmless warning from CMake 3.21 with the classic Python discovery.

@rwgk rwgk changed the title fix(build): aboid a possible warning about shadowed variables and changing behaviors fix(build): avoid a possible cmake warning about shadowed variables and changing behaviors Aug 26, 2021
@henryiii henryiii closed this Sep 20, 2021
@henryiii henryiii reopened this Sep 20, 2021
@henryiii henryiii merged commit 6ad3f87 into pybind:master Sep 23, 2021
@henryiii henryiii deleted the henryiii/fix/cmake321warn branch September 23, 2021 19:42
@github-actions github-actions bot added the needs changelog Possibly needs a changelog entry label Sep 23, 2021
@henryiii henryiii removed the needs changelog Possibly needs a changelog entry label Sep 24, 2021
@rwgk rwgk mentioned this pull request Feb 10, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Skylion007 Skylion007 Skylion007 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@henryiii @Skylion007